diff --git a/review_report.txt b/review_report.txt new file mode 100644 index 0000000..0024ea9 --- /dev/null +++ b/review_report.txt @@ -0,0 +1,12 @@ +═══════════════════════════════════════════════════════════════ +🔍 AsEnumerable/AsQueryable/ToList 完整 REVIEW +═══════════════════════════════════════════════════════════════ + +檢查範圍:Batch 1-3 所有已修改文件 +檢查標準: + ✅ 最佳選擇 - 性能和可讀性都最優 + ⚠️ 可優化 - 可以進一步優化 + ❌ 需修正 - 存在明顯問題 + +═══════════════════════════════════════════════════════════════ + diff --git a/web/App_Code/api/FollowerController.cs b/web/App_Code/api/FollowerController.cs index 872eeff..0d841fb 100644 --- a/web/App_Code/api/FollowerController.cs +++ b/web/App_Code/api/FollowerController.cs @@ -340,10 +340,9 @@ public class FollowerController : ApiController //int ccc = cc.Count(); - - - var ccList = cc.ToList(); - var qry = _db.followers.Where(f => ccList.Contains(f.num) || (f.leader.HasValue && ccList.Contains(f.leader.Value))); + // 優化:使用子查詢在數據庫層面執行,避免載入所有家族成員 ID + // 生成 SQL: WHERE num IN (SELECT...) OR leader IN (SELECT...) + var qry = _db.followers.Where(f => cc.Contains(f.num) || (f.leader.HasValue && cc.Contains(f.leader.Value)));